From 73c2bb5a88915957181d6d6dcaeebfa9963c354d Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Fri, 3 Nov 2017 18:59:42 +0100 Subject: [PATCH] src: fix -Winconsistent-missing-override warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix a compiler warning that was introduced in commit 4db1bc8f205 ("http2: allocate on every chunk send") by adding an `override` keyword. PR-URL: https://github.com/nodejs/node/pull/16726 Reviewed-By: Anatoli Papirovski Reviewed-By: Colin Ihrig Reviewed-By: Daniel Bevenius Reviewed-By: Franziska Hinkelmann Reviewed-By: James M Snell Reviewed-By: Michael Dawson Reviewed-By: Michaƫl Zasso --- src/node_http2.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/node_http2.h b/src/node_http2.h index 91a04e00f4a96c..9ac1f447eb1621 100644 --- a/src/node_http2.h +++ b/src/node_http2.h @@ -444,7 +444,7 @@ class Http2Session : public AsyncWrap, const SubmitTrailers& submit_trailers) override; void Send(WriteWrap* req, char* buf, size_t length) override; - WriteWrap* AllocateSend(); + WriteWrap* AllocateSend() override; int DoWrite(WriteWrap* w, uv_buf_t* bufs, size_t count, uv_stream_t* send_handle) override;