Skip to content
Permalink
Browse files

src: fix compiler warnings in node_crypto.cc

During the time between #24234
being opened and it landing, a V8 update occurred that deprecated
several APIs. This commit fixes the following compiler warnings:

../src/node_crypto.cc:3342:11:
  warning: 'Set' is deprecated: Use maybe version

../src/node_crypto.cc:3345:13:
  warning: 'GetFunction' is deprecated: Use maybe version

PR-URL: #25205
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  • Loading branch information...
cjihrig authored and targos committed Dec 24, 2018
1 parent 7365b00 commit 73ccfc81c91779a68df6c5b74fad0de0a0e8ea2c
Showing with 5 additions and 3 deletions.
  1. +5 −3 src/node_crypto.cc
@@ -3312,10 +3312,12 @@ Local<Function> KeyObject::Initialize(Environment* env, Local<Object> target) {
GetAsymmetricKeyType);
env->SetProtoMethod(t, "export", Export);

target->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "KeyObject"),
t->GetFunction(env->context()).ToLocalChecked());
auto function = t->GetFunction(env->context()).ToLocalChecked();
target->Set(env->context(),
FIXED_ONE_BYTE_STRING(env->isolate(), "KeyObject"),
function).FromJust();

return t->GetFunction();
return function;
}

Local<Object> KeyObject::Create(Environment* env,

0 comments on commit 73ccfc8

Please sign in to comment.
You can’t perform that action at this time.