Permalink
Browse files

test: mark test-async-wrap-uncaughtexception as flaky

`parallel/test-async-wrap-uncaughtexception.js` has become flaky.
At this time investigating the cause is still on going, but this issue
become has prevalent. In order to restore CI status to be relevant,
this marks the test as explicitly FLAKY.

PR-URL: #16694
Refs: #16210
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information...
refack committed Nov 2, 2017
1 parent b6df87e commit 75095d700137e29ad1413972b8f6eed7c3473a65
Showing with 2 additions and 0 deletions.
  1. +2 −0 test/parallel/parallel.status
@@ -5,6 +5,8 @@ prefix parallel
# sample-test : PASS,FLAKY
[true] # This section applies to all platforms
# https://github.com/nodejs/node/issues/16210
test-async-wrap-uncaughtexception

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 3, 2017

Member

This is malformed and will not skip the test. It is missing the : PASS, FLAKY

PR to fix and quick land coming soon...

@Trott

Trott Nov 3, 2017

Member

This is malformed and will not skip the test. It is missing the : PASS, FLAKY

PR to fix and quick land coming soon...

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 3, 2017

Member

(And yeah, I approved this, so shame on me.)

@Trott

Trott Nov 3, 2017

Member

(And yeah, I approved this, so shame on me.)

This comment has been minimized.

Show comment
Hide comment
@Trott

Trott Nov 3, 2017

Member

Fixed in #16702

@Trott

Trott Nov 3, 2017

Member

Fixed in #16702

This comment has been minimized.

Show comment
Hide comment
@refack

refack Nov 3, 2017

Member

😄 well it definitely solved the red CI issue

@refack

refack Nov 3, 2017

Member

😄 well it definitely solved the red CI issue

[$system==win32]

0 comments on commit 75095d7

Please sign in to comment.