Permalink
Browse files

test: modernize JS and tighten equality checking

Node todo process example with the follow test-net-binary.js changes:

var --> const where applicable

==, assert.equal--> ===, assert.strictEqual for all cases

PR-URL: #8476
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
pogilvie authored and Trott committed Sep 10, 2016
1 parent 77e9679 commit 759cf172280e8ce449a53e97f554fcd8e96e1de2
Showing with 12 additions and 12 deletions.
  1. +12 −12 test/parallel/test-net-binary.js
@@ -1,14 +1,14 @@
/* eslint-disable strict */
require('../common');
var assert = require('assert');
var net = require('net');
const assert = require('assert');
const net = require('net');
var binaryString = '';
for (var i = 255; i >= 0; i--) {
var s = '\'\\' + i.toString(8) + '\'';
var S = eval(s);
assert.ok(S.charCodeAt(0) == i);
assert.ok(S == String.fromCharCode(i));
const s = `'\\${i.toString(8)}'`;
const S = eval(s);
assert.strictEqual(S.charCodeAt(0), i);
assert.strictEqual(S, String.fromCharCode(i));
binaryString += S;
}
@@ -28,13 +28,13 @@ var recv = '';
echoServer.on('listening', function() {
var j = 0;
var c = net.createConnection({
const c = net.createConnection({
port: this.address().port
});
c.setEncoding('latin1');
c.on('data', function(chunk) {
var n = j + chunk.length;
const n = j + chunk.length;
while (j < n && j < 256) {
c.write(String.fromCharCode(j), 'latin1');
j++;
@@ -57,11 +57,11 @@ echoServer.on('listening', function() {
process.on('exit', function() {
assert.equal(2 * 256, recv.length);
var a = recv.split('');
const a = recv.split('');
var first = a.slice(0, 256).reverse().join('');
const first = a.slice(0, 256).reverse().join('');
var second = a.slice(256, 2 * 256).join('');
const second = a.slice(256, 2 * 256).join('');
assert.equal(first, second);
assert.strictEqual(first, second);
});

0 comments on commit 759cf17

Please sign in to comment.