Skip to content
Browse files

src: fix -Winconsistent-missing-override warning

This commit addresses the following warning:

../src/ warning: 'mark_arraybuffer_as_untransferable'
overrides a member function but is not marked 'override'
  v8::Maybe<bool> mark_arraybuffer_as_untransferable(
../src/js_native_api_v8.h:42:27: note: overridden virtual function is here
  virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable(

PR-URL: #30549
Reviewed-By: Anna Henningsen <>
Reviewed-By: Ben Noordhuis <>
Reviewed-By: Ruben Bridgewater <>
Reviewed-By: Jiawen Geng <>
Reviewed-By: David Carlier <>
  • Loading branch information
cjihrig authored and targos committed Nov 19, 2019
1 parent 888f8ff commit 7a5954ef26c49f53d40a516df60800a119fb9da7
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/
@@ -26,7 +26,7 @@ struct node_napi_env__ : public napi_env__ {

v8::Maybe<bool> mark_arraybuffer_as_untransferable(
v8::Local<v8::ArrayBuffer> ab) const {
v8::Local<v8::ArrayBuffer> ab) const override {
return ab->SetPrivate(

0 comments on commit 7a5954e

Please sign in to comment.
You can’t perform that action at this time.