From 7cb05cf2a072e6edcb7fc761f626d9525880152f Mon Sep 17 00:00:00 2001 From: Anatoli Papirovski Date: Thu, 7 Jun 2018 17:59:49 -0400 Subject: [PATCH] tls: remove SLAB_BUFFER_SIZE This constant has not been in use for many years now and the test alongside it is invalid, as well as flaky. PR-URL: https://github.com/nodejs/node/pull/21199 Reviewed-By: Anna Henningsen Reviewed-By: Trivikram Kamat Reviewed-By: Joyee Cheung Reviewed-By: Ujjwal Sharma Reviewed-By: Colin Ihrig Reviewed-By: James M Snell --- lib/tls.js | 2 - test/parallel/test-https-req-split.js | 66 --------------------------- 2 files changed, 68 deletions(-) delete mode 100644 test/parallel/test-https-req-split.js diff --git a/lib/tls.js b/lib/tls.js index ddc84aab8bb03d..ad752071418fe1 100644 --- a/lib/tls.js +++ b/lib/tls.js @@ -44,8 +44,6 @@ const _tls_wrap = require('_tls_wrap'); exports.CLIENT_RENEG_LIMIT = 3; exports.CLIENT_RENEG_WINDOW = 600; -exports.SLAB_BUFFER_SIZE = 10 * 1024 * 1024; - exports.DEFAULT_CIPHERS = process.binding('constants').crypto.defaultCipherList; diff --git a/test/parallel/test-https-req-split.js b/test/parallel/test-https-req-split.js deleted file mode 100644 index 05fc85fc07b781..00000000000000 --- a/test/parallel/test-https-req-split.js +++ /dev/null @@ -1,66 +0,0 @@ -// Copyright Joyent, Inc. and other Node contributors. -// -// Permission is hereby granted, free of charge, to any person obtaining a -// copy of this software and associated documentation files (the -// "Software"), to deal in the Software without restriction, including -// without limitation the rights to use, copy, modify, merge, publish, -// distribute, sublicense, and/or sell copies of the Software, and to permit -// persons to whom the Software is furnished to do so, subject to the -// following conditions: -// -// The above copyright notice and this permission notice shall be included -// in all copies or substantial portions of the Software. -// -// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS -// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF -// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN -// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, -// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR -// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE -// USE OR OTHER DEALINGS IN THE SOFTWARE. - -'use strict'; -const common = require('../common'); -const fixtures = require('../common/fixtures'); -if (!common.hasCrypto) - common.skip('missing crypto'); - -// disable strict server certificate validation by the client -process.env.NODE_TLS_REJECT_UNAUTHORIZED = '0'; - -const https = require('https'); - -const tls = require('tls'); - -const options = { - key: fixtures.readKey('agent1-key.pem'), - cert: fixtures.readKey('agent1-cert.pem') -}; - -// Force splitting incoming data -tls.SLAB_BUFFER_SIZE = 1; - -const server = https.createServer(options); -server.on('upgrade', common.mustCall(function(req, socket, upgrade) { - socket.on('data', function(data) { - throw new Error(`Unexpected data: ${data}`); - }); - socket.end('HTTP/1.1 200 Ok\r\n\r\n'); -})); - -server.listen(0, function() { - const req = https.request({ - host: '127.0.0.1', - port: this.address().port, - agent: false, - headers: { - Connection: 'Upgrade', - Upgrade: 'Websocket' - } - }, function() { - req.socket.destroy(); - server.close(); - }); - - req.end(); -});