Skip to content
Permalink
Browse files

build: remove --code-cache-path help option

This commit removes the now obsolete option.

PR-URL: #28446
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information...
danbev authored and targos committed Jun 27, 2019
1 parent f0c436f commit 7d3ddfe6b899be17291ce1b9365da5e86b8e0a10
Showing with 2 additions and 7 deletions.
  1. +1 −6 configure.py
  2. +1 −1 test/parallel/test-code-cache.js
@@ -515,11 +515,6 @@
dest='without_siphash',
help=optparse.SUPPRESS_HELP)

parser.add_option('--code-cache-path',
action='store',
dest='code_cache_path',
help='optparse.SUPPRESS_HELP')

# End dummy list.

parser.add_option('--without-ssl',
@@ -1116,7 +1111,7 @@ def configure_node(o):
o['variables']['node_no_browser_globals'] = b(options.no_browser_globals)
# TODO(refack): fix this when implementing embedded code-cache when cross-compiling.
if o['variables']['want_separate_host_toolset'] == 0:
o['variables']['node_code_cache_path'] = 'yes'
o['variables']['node_code_cache'] = 'yes' # For testing
o['variables']['node_shared'] = b(options.shared)
node_module_version = getmoduleversion.get_version()

@@ -47,7 +47,7 @@ if (!process.features.cached_builtins) {
}
} else { // Native compiled
assert.strictEqual(
process.config.variables.node_code_cache_path,
process.config.variables.node_code_cache,
'yes'
);

0 comments on commit 7d3ddfe

Please sign in to comment.
You can’t perform that action at this time.