Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
test: optimize test-http2-large-file
Optimize test-http2-large-file so it only allocates a single buffer.

PR-URL: #26737
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
  • Loading branch information
Trott authored and targos committed Mar 27, 2019
1 parent 5b8eae4 commit 7ebd6bd
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions test/sequential/test-http2-large-file.js
@@ -1,6 +1,6 @@
'use strict';

// Test to ensure sending a large stream with a large initial window size works
// Test sending a large stream with a large initial window size.
// See: https://github.com/nodejs/node/issues/19141

const common = require('../common');
Expand All @@ -18,14 +18,15 @@ server.on('stream', (stream) => {

server.listen(0, common.mustCall(() => {
let remaining = 1e8;
const chunk = 1e6;
const chunkLength = 1e6;
const chunk = Buffer.alloc(chunkLength, 'a');
const client = http2.connect(`http://localhost:${server.address().port}`,
{ settings: { initialWindowSize: 6553500 } });
const request = client.request({ ':method': 'POST' });
function writeChunk() {
if (remaining > 0) {
remaining -= chunk;
request.write(Buffer.alloc(chunk, 'a'), writeChunk);
remaining -= chunkLength;
request.write(chunk, writeChunk);
} else {
request.end();
}
Expand Down

0 comments on commit 7ebd6bd

Please sign in to comment.