Permalink
Browse files

src: remove process._debugPause()

This method is undocumented and depends on a V8 API that is slated for
removal.  The inspector and node-inspect don't use it and I could find
no third-party code that depends on it.  Remove it.

PR-URL: #17060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
  • Loading branch information...
bnoordhuis committed Nov 15, 2017
1 parent f526deb commit 804eb3cd734176f123142f0db496279cb2f645fd
Showing with 0 additions and 8 deletions.
  1. +0 −8 src/node.cc
View
@@ -67,7 +67,6 @@
#if NODE_USE_V8_PLATFORM
#include "libplatform/libplatform.h"
#endif // NODE_USE_V8_PLATFORM
#include "v8-debug.h"
#include "v8-profiler.h"
#include "zlib.h"
@@ -2931,7 +2930,6 @@ static void DebugPortSetter(Local<Name> property,
static void DebugProcess(const FunctionCallbackInfo<Value>& args);
static void DebugPause(const FunctionCallbackInfo<Value>& args);
static void DebugEnd(const FunctionCallbackInfo<Value>& args);
namespace {
@@ -3363,7 +3361,6 @@ void SetupProcessObject(Environment* env,
env->SetMethod(process, "_kill", Kill);
env->SetMethod(process, "_debugProcess", DebugProcess);
env->SetMethod(process, "_debugPause", DebugPause);
env->SetMethod(process, "_debugEnd", DebugEnd);
env->SetMethod(process, "hrtime", Hrtime);
@@ -4091,11 +4088,6 @@ static void DebugProcess(const FunctionCallbackInfo<Value>& args) {
#endif // _WIN32
static void DebugPause(const FunctionCallbackInfo<Value>& args) {
v8::Debug::DebugBreak(args.GetIsolate());
}
static void DebugEnd(const FunctionCallbackInfo<Value>& args) {
#if HAVE_INSPECTOR
Environment* env = Environment::GetCurrent(args);

0 comments on commit 804eb3c

Please sign in to comment.