Permalink
Browse files

test: remove uses of common.PORT in test-tls-client tests

Change common.PORT to '0' to avoid the possibility of getting EADDRINUSE error
if another test in 'parallel' uses port '0' at the same time.

PR-URL: #12461
Ref: #12376
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information...
z0al authored and jasnell committed Apr 17, 2017
1 parent 6a1275d commit 825d3909abcea2eed42d162e3dc35db69e8278d7
Showing with 2 additions and 2 deletions.
  1. +1 −1 test/parallel/test-tls-client-abort.js
  2. +1 −1 test/parallel/test-tls-client-abort2.js
@@ -35,7 +35,7 @@ const path = require('path');
const cert = fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'));
const key = fs.readFileSync(path.join(common.fixturesDir, 'test_key.pem'));
-const conn = tls.connect({cert, key, port: common.PORT}, common.mustNotCall());
+const conn = tls.connect({cert, key, port: 0}, common.mustNotCall());
conn.on('error', function() {
});
assert.doesNotThrow(function() {
@@ -29,7 +29,7 @@ if (!common.hasCrypto) {
}
const tls = require('tls');
-const conn = tls.connect(common.PORT, common.mustNotCall());
+const conn = tls.connect(0, common.mustNotCall());
conn.on('error', common.mustCall(function() {
assert.doesNotThrow(function() {
conn.destroy();

0 comments on commit 825d390

Please sign in to comment.