Skip to content
Permalink
Browse files

test: remove message argument from strictEqual()

In test/parallel/test-require-process.js, the last thing in the test is
a call to assert.strictEqual(). It has a string literal as its third
argument. Unfortunately, that means that the diff between the two values
being compared will be suppressed if there is an AssertionError. That's
not helpful for debugging.

This is fixed by removing the third argument from the call. It is,
however, preserved in a comment above the call to assert.strictEqual().

PR-URL: #20912
Fixes: #20911
Refs: https://www.nodetodo.org/getting-started
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information...
sagirk authored and BridgeAR committed May 23, 2018
1 parent 4970cd6 commit 84954523c8a663e61cea82a35b883abcdf180082
Showing with 2 additions and 2 deletions.
  1. +2 −2 test/parallel/test-require-process.js
@@ -3,5 +3,5 @@ require('../common');
const assert = require('assert');

const nativeProcess = require('process');
assert.strictEqual(nativeProcess, process,
'require("process") should return global process reference');
// require('process') should return global process reference
assert.strictEqual(nativeProcess, process);

0 comments on commit 8495452

Please sign in to comment.
You can’t perform that action at this time.