Please sign in to comment.
lib: make tick processor detect xcodebuild errors
`node --prof-process` on macOS calls out to nm(1) to look up C++ symbols. If Xcode hasn't been properly installed or its license hasn't been accepted yet, it prints out an error and exits. Before this commit, that error was swallowed and the output of the tick processor was not showing the C++ entry points. This commit detects that error message and turns it into an exception. No regression test because this particular condition is hard to test for without going to extreme lengths to mock the output of nm. Fixes: #29804 PR-URL: #29830 Reviewed-By: David Carlier <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: Ruben Bridgewater <firstname.lastname@example.org> Reviewed-By: Minwoo Jung <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org>
- Loading branch information...