From 87e3d3db894ee1ea1b3333ae53e8f1c627a2a884 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 10 Jan 2018 09:07:54 -0500 Subject: [PATCH] src: fix code coverage cleanup In https://github.com/nodejs/node/pull/17987 which updated the location of the code coverage patches I missed a few changes needed to properly clean up for code coverage. Add these. PR-URL: https://github.com/nodejs/node/pull/18081 Reviewed-By: Colin Ihrig Reviewed-By: Anna Henningsen Reviewed-By: Jon Moss Reviewed-By: James M Snell --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index cca7eccfa10681..1e55e7d7ed5275 100644 --- a/Makefile +++ b/Makefile @@ -145,7 +145,7 @@ check: test coverage-clean: if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi $(RM) -r node_modules - $(RM) -r gcovr testing + $(RM) -r gcovr build $(RM) -r out/$(BUILDTYPE)/.coverage $(RM) -r .cov_tmp $(RM) out/$(BUILDTYPE)/obj.target/node/{src,gen}/*.gcda @@ -172,7 +172,7 @@ coverage-build: all $(NODE) ./deps/npm install nyc --no-save --no-package-lock; fi if [ ! -d gcovr ]; then git clone --depth=1 \ --single-branch git://github.com/gcovr/gcovr.git; fi - if [ ! -d testing ]; then git clone --depth=1 \ + if [ ! -d build ]; then git clone --depth=1 \ --single-branch https://github.com/nodejs/build.git; fi if [ ! -f gcovr/scripts/gcovr.orig ]; then \ (cd gcovr && patch -N -p1 < \