Please sign in to comment.
http2: do not create ArrayBuffers when no DATA received
Lazily allocate `ArrayBuffer`s for the contents of DATA frames. Creating `ArrayBuffer`s is, sadly, not a cheap operation with V8. This is part of performance improvements to mitigate CVE-2019-9513. Together with the previous commit, these changes improve throughput in the adversarial case by about 100 %, and there is little more that we can do besides artificially limiting the rate of incoming metadata frames (i.e. after this patch, CPU usage is virtually exclusively in libnghttp2). PR-URL: #29122 Reviewed-By: Rich Trott <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com>
- Loading branch information...
Showing with 17 additions and 7 deletions.