From 88b904cf2463de704df849935b082c6bb9a97b0c Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Wed, 25 Jan 2023 19:07:53 +0100 Subject: [PATCH] tools: require more trailing commas MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit All of the import and export statements in the codebase already use trailing commas, this commit adds a linter rule to enforce that. PR-URL: https://github.com/nodejs/node/pull/46346 Reviewed-By: Michaël Zasso Reviewed-By: Filip Skokan Reviewed-By: Darshan Sen Reviewed-By: Colin Ihrig --- benchmark/.eslintrc.yaml | 4 ++-- lib/.eslintrc.yaml | 4 ++-- test/.eslintrc.yaml | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/benchmark/.eslintrc.yaml b/benchmark/.eslintrc.yaml index 821b2381d3e215..7802df7c2f97cb 100644 --- a/benchmark/.eslintrc.yaml +++ b/benchmark/.eslintrc.yaml @@ -7,9 +7,9 @@ env: rules: comma-dangle: [error, { arrays: always-multiline, - exports: only-multiline, + exports: always-multiline, functions: only-multiline, - imports: only-multiline, + imports: always-multiline, objects: only-multiline, }] prefer-arrow-callback: error diff --git a/lib/.eslintrc.yaml b/lib/.eslintrc.yaml index 2cc6ca904ee76f..ff790e49821d28 100644 --- a/lib/.eslintrc.yaml +++ b/lib/.eslintrc.yaml @@ -4,9 +4,9 @@ env: rules: comma-dangle: [error, { arrays: always-multiline, - exports: only-multiline, + exports: always-multiline, functions: only-multiline, - imports: only-multiline, + imports: always-multiline, objects: only-multiline, }] prefer-object-spread: error diff --git a/test/.eslintrc.yaml b/test/.eslintrc.yaml index b3e39ecf45b797..3c5ecdb3e44fec 100644 --- a/test/.eslintrc.yaml +++ b/test/.eslintrc.yaml @@ -90,8 +90,8 @@ overrides: rules: comma-dangle: [error, { arrays: always-multiline, - exports: only-multiline, + exports: always-multiline, functions: only-multiline, - imports: only-multiline, + imports: always-multiline, objects: only-multiline, }]