Skip to content
Permalink
Browse files

domain: do not import util for a simple type check

This removes `require('util')` from the `domain` module. There was
only a single simple type check used from the `util` module which
is now inlined instead.

PR-URL: #29825
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
  • Loading branch information
BridgeAR authored and targos committed Oct 3, 2019
1 parent 5ade490 commit 8a333a4519716e9927b433659c392489d73f4377
Showing with 1 addition and 2 deletions.
  1. +1 −2 lib/domain.js
@@ -28,7 +28,6 @@

const { Object, Reflect } = primordials;

const util = require('util');
const EventEmitter = require('events');
const {
ERR_DOMAIN_CALLBACK_NOT_AVAILABLE,
@@ -207,7 +206,7 @@ Domain.prototype.members = undefined;
Domain.prototype._errorHandler = function(er) {
var caught = false;

if (!util.isPrimitive(er)) {
if ((typeof er === 'object' && er !== null) || typeof er === 'function') {
Object.defineProperty(er, 'domain', {
configurable: true,
enumerable: false,

0 comments on commit 8a333a4

Please sign in to comment.
You can’t perform that action at this time.