Permalink
Browse files

test:replace indexOf, assert.equal, add mustCall()

replace indexOf with includes
replace assert.equal with assert.strictEqual
add common.mustCall
replace throw error with assert.ifError

PR-URL: #8766
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
richHong authored and Trott committed Sep 24, 2016
1 parent 7f7502d commit 8cd2306cc3e3ea379c569ecb90f0af2afa6345e3
Showing with 8 additions and 8 deletions.
  1. +8 −8 test/parallel/test-fs-symlink.js
@@ -12,7 +12,7 @@ if (common.isWindows) {
// On Windows, creating symlinks requires admin privileges.
// We'll only try to run symlink test if we have enough privileges.
exec('whoami /priv', function(err, o) {
if (err || o.indexOf('SeCreateSymbolicLinkPrivilege') == -1) {
if (err || !o.includes('SeCreateSymbolicLinkPrivilege')) {
common.skip('insufficient privileges');
return;
}
@@ -25,24 +25,24 @@ common.refreshTmpDir();
const linkData = path.join(common.fixturesDir, '/cycles/root.js');
const linkPath = path.join(common.tmpDir, 'symlink1.js');
fs.symlink(linkData, linkPath, function(err) {
if (err) throw err;
fs.symlink(linkData, linkPath, common.mustCall(function(err) {
assert.ifError(err);
fs.lstat(linkPath, common.mustCall(function(err, stats) {
if (err) throw err;
assert.ifError(err);
linkTime = stats.mtime.getTime();
}));
fs.stat(linkPath, common.mustCall(function(err, stats) {
if (err) throw err;
assert.ifError(err);
fileTime = stats.mtime.getTime();
}));
fs.readlink(linkPath, common.mustCall(function(err, destination) {
if (err) throw err;
assert.equal(destination, linkData);
assert.ifError(err);
assert.strictEqual(destination, linkData);
}));
});
}));
process.on('exit', function() {

0 comments on commit 8cd2306

Please sign in to comment.