Skip to content
Permalink
Browse files

test: improve test-gc-http-client-onerror

* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
lundibundi authored and MylesBorins committed Oct 1, 2018
1 parent 6bea43c commit 8d091c2dd372767f3c7be87b2fd419c45a2139b4
Showing with 19 additions and 22 deletions.
  1. +19 −22 test/sequential/test-gc-http-client-onerror.js
@@ -3,7 +3,7 @@
// just like test-gc-http-client.js,
// but with an on('error') handler that does nothing.

require('../common');
const common = require('../common');
const onGC = require('../common/ongc');

function serverHandler(req, res) {
@@ -21,37 +21,34 @@ let countGC = 0;
console.log(`We should do ${todo} requests`);

const server = http.createServer(serverHandler);
server.listen(0, runTest);
server.listen(0, common.mustCall(() => {
for (let i = 0; i < 10; i++)
getall();
}));

function getall() {
if (count >= todo)
return;

(function() {
function cb(res) {
res.resume();
done += 1;
}
function onerror(er) {
throw er;
}
const req = http.get({
hostname: 'localhost',
pathname: '/',
port: server.address().port
}, cb).on('error', onerror);

const req = http.get({
hostname: 'localhost',
pathname: '/',
port: server.address().port
}, cb).on('error', onerror);

count++;
onGC(req, { ongc });
})();
count++;
onGC(req, { ongc });

setImmediate(getall);
}

function runTest() {
for (let i = 0; i < 10; i++)
getall();
function cb(res) {
res.resume();
done += 1;
}

function onerror(err) {
throw err;
}

function ongc() {

0 comments on commit 8d091c2

Please sign in to comment.
You can’t perform that action at this time.