Permalink
Browse files

test: improve error messages in test-npm-install

PR-URL: #11027
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
  • Loading branch information...
gonenduk authored and italoacasas committed Jan 26, 2017
1 parent 17314eb commit 8d2a9138fc5f7a98ff3a2247df467a2ec945dd1c
Showing with 2 additions and 2 deletions.
  1. +2 −2 test/parallel/test-npm-install.js
@@ -53,8 +53,8 @@ const proc = spawn(process.execPath, args, {
});
function handleExit(code, signalCode) {
- assert.strictEqual(code, 0, 'npm install should run without an error');
- assert.ok(signalCode === null, 'signalCode should be null');
+ assert.strictEqual(code, 0, `npm install got error code ${code}`);
+ assert.strictEqual(signalCode, null, `unexpected signal: ${signalCode}`);
assert.doesNotThrow(function() {
fs.accessSync(installDir + '/node_modules/package-name');
});

0 comments on commit 8d2a913

Please sign in to comment.