Please sign in to comment.
test: check zlib version for createDeflateRaw
We are currenly builing Node with --shared-zlib which happens to be version 1.2.8. The test for zlib.createDeflateRaw is expected to fail but does not when using version 1.2.8. As far as I can tell the fix referred to in the comments was introduced in version 1.2.9: - Reject a window size of 256 bytes if not using the zlib wrapper This commit suggests adding a check for the version and skipping this assert if the version is less than 1.2.9. Refs: http://zlib.net/ChangeLog.txt Backport-PR-URL: #15478 PR-URL: #13697 Reviewed-By: Benjamin Gruenbaum <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Luigi Pinca <email@example.com> Reviewed-By: Anna Henningsen <firstname.lastname@example.org> Reviewed-By: Richard Lau <email@example.com>
- Loading branch information...