Permalink
Browse files

test: fix common.PIPE path bug

`common.PIPE` is returning a path name in `test` rather than in the
`tmp` directory for each test. This is causing multiple test failures in
CI. Make the path name inside the temporary directories again. This way
the pipe is removed by `common.refreshTmpDir()` on POSIX.

The bug in `common.PIPE` was introduced in
c34ae48.

PR-URL: #16364
Fixes: #16290
Fixes: #16323
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
  • Loading branch information...
Trott committed Oct 21, 2017
1 parent fe4675b commit 8e268c70dd5b5d98658544a5d46cd8d8d4b17481
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/common/index.js
View
@@ -274,7 +274,7 @@ Object.defineProperty(exports, 'hasFipsCrypto', {
const localRelative = path.relative(process.cwd(), `${exports.tmpDir}/`);
const pipePrefix = exports.isWindows ? '\\\\.\\pipe\\' : localRelative;
const pipeName = `node-test.${process.pid}.sock`;
exports.PIPE = pipePrefix + pipeName;
exports.PIPE = path.join(pipePrefix, pipeName);
}
{

0 comments on commit 8e268c7

Please sign in to comment.