Skip to content
Permalink
Browse files

src: remove icuDataDir from node config

icuDataDir seems to be redundant as it is not used anywhere.
Hence removing it.

PR-URL: #24780
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information...
GauthamBanasandra authored and Trott committed Dec 2, 2018
1 parent 06134e3 commit 9021b0d3fcac507b335bd1117155e555adbd7c28
Showing with 0 additions and 4 deletions.
  1. +0 −4 src/node_config.cc
@@ -49,10 +49,6 @@ static void Initialize(Local<Object> target,
READONLY_TRUE_PROPERTY(target, "hasNodeOptions");
#endif

// TODO(addaleax): This seems to be an unused, private API. Remove it?
READONLY_STRING_PROPERTY(target, "icuDataDir",
per_process_opts->icu_data_dir);

#endif // NODE_HAVE_I18N_SUPPORT

if (env->options()->preserve_symlinks)

0 comments on commit 9021b0d

Please sign in to comment.
You can’t perform that action at this time.