Skip to content
Browse files

test: see value of "hadError" in tls test

The existing implementation created a state that if the assert failed
we got an error message without the values of hadError.
Removed the default error message and added a comment explaining the

PR-URL: #22069
Reviewed-By: Anna Henningsen <>
Reviewed-By: Colin Ihrig <>
Reviewed-By: Rich Trott <>
Reviewed-By: Benjamin Gruenbaum <>
Reviewed-By: Jon Moss <>
Reviewed-By: James M Snell <>
Reviewed-By: Luigi Pinca <>
Reviewed-By: Ruben Bridgewater <>
  • Loading branch information...
oryanmoshe authored and Trott committed Aug 1, 2018
1 parent d2ffcac commit 90972d5cb6477adfa907f2a8e4326908ef93c7ef
Showing with 2 additions and 1 deletion.
  1. +2 −1 test/parallel/test-tls-hello-parser-failure.js
@@ -60,6 +60,7 @@ const server = tls.createServer(options, function(c) {

client.on('close', common.mustCall(function(hadError) {
assert.strictEqual(hadError, true, 'Client never errored');
// Confirm that client errored
assert.strictEqual(hadError, true);

0 comments on commit 90972d5

Please sign in to comment.
You can’t perform that action at this time.