Skip to content
Permalink
Browse files

tools: fix mixup with bytes.decode() and str.encode()

We want to read a bytes file and decode the contents as utf-8 so we can
compare against a utf-8 pattern.

PR-URL: #29208
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information...
cclauss authored and BridgeAR committed Aug 19, 2019
1 parent 35bca31 commit 925141f946a40014e25b06ef27425866ea8153cd
Showing with 2 additions and 2 deletions.
  1. +2 −2 tools/v8_gypfiles/GN-scraper.py
@@ -7,8 +7,8 @@
def DoMain(args):
gn_filename, pattern = args
src_root = os.path.dirname(gn_filename)
with open(gn_filename, 'r') as gn_file:
gn_content = gn_file.read().encode('utf-8')
with open(gn_filename, 'rb') as gn_file:
gn_content = gn_file.read().decode('utf-8')

scraper_re = re.compile(pattern + r'\[([^\]]+)', re.DOTALL)
matches = scraper_re.search(gn_content)

0 comments on commit 925141f

Please sign in to comment.
You can’t perform that action at this time.