Please sign in to comment.
test: remove string literals from assert.strictEqual() calls
In test/parallel/test-intl.js, five calls to assert.strictEqual() use a third, string-literal parameter, which specifies a message to display when the assertion fails. The problem is that if the assertion fails, the error message will show the string literal but not the values that caused the assertion to fail. This commit removes the third parameter from the five calls and makes them comments above the assertions instead. The default error message produced by assert.strictEqual() shows the values that caused the assertion to fail, which should be somewhat more helpful. PR-URL: #21211 Reviewed-By: James M Snell <firstname.lastname@example.org> Reviewed-By: Rich Trott <email@example.com> Reviewed-By: Luigi Pinca <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: Trivikram Kamat <firstname.lastname@example.org>
- Loading branch information...