Permalink
Browse files

fs: re-enable watch facility in AIX

On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
  • Loading branch information...
gireeshpunathil authored and italoacasas committed Dec 2, 2016
1 parent d5b1a4b commit 9339891b0759984ff82baf0c3734910e3ef36c20
Showing with 16 additions and 7 deletions.
  1. +7 −0 doc/api/fs.md
  2. +0 −7 test/parallel/parallel.status
  3. +9 −0 test/parallel/test-fs-watch-encoding.js
View
@@ -1752,6 +1752,13 @@ a new inode. The watch will emit an event for the delete but will continue
watching the *original* inode. Events for the new inode will not be emitted.
This is expected behavior.
In AIX, save and close of a file being watched causes two notifications -
one for adding new content, and one for truncation. Moreover, save and
close operations on some platforms cause inode changes that force watch
operations to become invalid and ineffective. AIX retains inode for the
lifetime of a file, that way though this is different from Linux / OS X,
this improves the usability of file watching. This is expected behavior.
#### Filename Argument
<!--type=misc-->
@@ -18,10 +18,3 @@ prefix parallel
[$system==freebsd]
# fs-watch currently needs special configuration on AIX and we
# want to improve under https://github.com/nodejs/node/issues/5085.
# Tests are disabled so CI can be green and we can spot other
# regressions until this work is complete
[$system==aix]
test-fs-watch-enoent : FAIL, PASS
test-fs-watch-encoding : FAIL, PASS
@@ -14,6 +14,15 @@ const common = require('../common');
const fs = require('fs');
const path = require('path');
// fs-watch on folders have limited capability in AIX.
// The testcase makes use of folder watching, and causes
// hang. This behavior is documented. Skip this for AIX.
if (common.isAix) {
common.skip('folder watch capability is limited in AIX.');
return;
}
common.refreshTmpDir();
const fn = '新建文夹件.txt';

0 comments on commit 9339891

Please sign in to comment.