Skip to content
Browse files

deps: cherry-pick 13a04aba from V8 upstream

Original commit message:
  fix: move V8_EXPORT_PRIVATE marks to prevent unresolvable references

  This change fixes missing symbol errors in the Windows 10 on ARM build
  of Node.js.

  When a whole class is marked for export, all of its members are marked
  as well. This can be a problem when inline members call undefined yet
  inline members of other classes: the exported function will contain a
  reference to the undefined inline function that should be satisfied at
  link time, but because the other function is inline no symbol will be
  produced that will satisfy that reference.

  Clang gets around this by masking inlined class members from export
  using /Fc:dllexportInlines-. This is why b0a2a567 worked.

  Node.js' Windows builds use MSVC and so do not have access to this
  flag. This results in unresolved symbols at link time.

  Bug: v8:9465
  Change-Id: Ief9c7ab6ba35d22f995939eb62a64d6f1992ed85
  Reviewed-by: Sigurd Schneider <>
  Reviewed-by: Jakob Gruber <>
  Commit-Queue: Sigurd Schneider <>
  Cr-Commit-Position: refs/heads/master@{#62660}

Refs: v8/v8@13a04ab
Backport-PR-URL: #28955
PR-URL: #28602
Reviewed-By: João Reis <>
Reviewed-By: Ben Noordhuis <>
Reviewed-By: Richard Lau <>
  • Loading branch information...
jkunkee authored and targos committed Jul 4, 2019
1 parent 9b3c115 commit 945955ff86e35575353699e2c965319e3bd6733d
Showing with 3 additions and 3 deletions.
  1. +1 −1 common.gypi
  2. +1 −1 deps/v8/src/codegen/arm64/decoder-arm64.h
  3. +1 −1 deps/v8/src/codegen/arm64/macro-assembler-arm64.h
@@ -38,7 +38,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.11',
'v8_embedder_string': '-node.12',

##### V8 defaults for Node.js #####

@@ -95,7 +95,7 @@ class V8_EXPORT_PRIVATE DecoderVisitor {

// A visitor that dispatches to a list of visitors.
class V8_EXPORT_PRIVATE DispatchingDecoderVisitor : public DecoderVisitor {
class DispatchingDecoderVisitor : public DecoderVisitor {
DispatchingDecoderVisitor() {}
virtual ~DispatchingDecoderVisitor() {}
@@ -1968,7 +1968,7 @@ class InstructionAccurateScope {
// original state, even if the lists were modified by some other means. Note
// that this scope can be nested but the destructors need to run in the opposite
// order as the constructors. We do not have assertions for this.
class V8_EXPORT_PRIVATE UseScratchRegisterScope {
class UseScratchRegisterScope {
explicit UseScratchRegisterScope(TurboAssembler* tasm)
: available_(tasm->TmpList()),

0 comments on commit 945955f

Please sign in to comment.
You can’t perform that action at this time.