Skip to content
Browse files

http2: remove unused FlushData() function

PR-URL: #29145
Reviewed-By: Michaël Zasso <>
Reviewed-By: Colin Ihrig <>
Reviewed-By: Jiawen Geng <>
Reviewed-By: Luigi Pinca <>
Reviewed-By: Rich Trott <>
Reviewed-By: Trivikram Kamat <>
Reviewed-By: James M Snell <>
  • Loading branch information...
addaleax authored and targos committed Aug 15, 2019
1 parent f9b61d2 commit 964dff8a9eb839b5afe1f97a823580a85742f968
Showing with 0 additions and 10 deletions.
  1. +0 −9 src/
  2. +0 −1 src/node_http2.h
@@ -2723,14 +2723,6 @@ void Http2Stream::Destroy(const FunctionCallbackInfo<Value>& args) {

// Prompt the Http2Stream to begin sending data to the JS land.
void Http2Stream::FlushData(const FunctionCallbackInfo<Value>& args) {
Http2Stream* stream;
ASSIGN_OR_RETURN_UNWRAP(&stream, args.Holder());
Debug(stream, "data flushed to js");

// Initiate a Push Promise and create the associated Http2Stream
void Http2Stream::PushPromise(const FunctionCallbackInfo<Value>& args) {
Environment* env = Environment::GetCurrent(args);
@@ -3129,7 +3121,6 @@ void Initialize(Local<Object> target,
stream->SetClassName(FIXED_ONE_BYTE_STRING(env->isolate(), "Http2Stream"));
env->SetProtoMethod(stream, "id", Http2Stream::GetID);
env->SetProtoMethod(stream, "destroy", Http2Stream::Destroy);
env->SetProtoMethod(stream, "flushData", Http2Stream::FlushData);
env->SetProtoMethod(stream, "priority", Http2Stream::Priority);
env->SetProtoMethod(stream, "pushPromise", Http2Stream::PushPromise);
env->SetProtoMethod(stream, "info", Http2Stream::Info);
@@ -581,7 +581,6 @@ class Http2Stream : public AsyncWrap,
// JavaScript API
static void GetID(const FunctionCallbackInfo<Value>& args);
static void Destroy(const FunctionCallbackInfo<Value>& args);
static void FlushData(const FunctionCallbackInfo<Value>& args);
static void Priority(const FunctionCallbackInfo<Value>& args);
static void PushPromise(const FunctionCallbackInfo<Value>& args);
static void RefreshState(const FunctionCallbackInfo<Value>& args);

0 comments on commit 964dff8

Please sign in to comment.
You can’t perform that action at this time.