Please sign in to comment.
lib: do not register DOMException in a module
Instead of registering it in a global scope of a native module and expecting that it only gets evaluated when the module is actually compiled and run and will not be evaluated because the module can be cached, directly register the DOMException constructor onto Environment during bootstrap for clarity, since this is a side effect that has to happen during bootstrap. PR-URL: #24708 Reviewed-By: Richard Lau <email@example.com> Reviewed-By: Colin Ihrig <firstname.lastname@example.org> Reviewed-By: Anna Henningsen <email@example.com> Reviewed-By: Tiancheng "Timothy" Gu <firstname.lastname@example.org> Reviewed-By: Luigi Pinca <email@example.com> Reviewed-By: James M Snell <firstname.lastname@example.org>
- Loading branch information...
Showing with 3 additions and 4 deletions.