Permalink
Browse files

test: move inspector tests to parallel/sequential

* remove inspector directory artifacts

PR-URL: #16197
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
maclover7 authored and refack committed Oct 14, 2017
1 parent ff747e3 commit 978629ca1240b9f2038390c7e960f3d226daa4e8
Showing with 23 additions and 45 deletions.
  1. +0 −3 Makefile
  2. +0 −1 test/README.md
  3. 0 test/{inspector → common}/inspector-helper.js
  4. 0 test/{inspector/global-function.js → fixtures/inspector-global-function.js}
  5. +0 −16 test/inspector/inspector.status
  6. +0 −6 test/inspector/testcfg.py
  7. +5 −0 test/parallel/parallel.status
  8. +1 −1 ...ector/test-async-hook-setup-at-inspect.js → parallel/test-inspect-async-hook-setup-at-inspect.js}
  9. +1 −1 ...-async-hook-setup-at-inspect-brk.js → parallel/test-inspector-async-hook-setup-at-inspect-brk.js}
  10. +1 −1 ...ector/test-async-hook-setup-at-signal.js → parallel/test-inspector-async-hook-setup-at-signal.js}
  11. 0 ...sync-hook-teardown-at-debug-end.js → parallel/test-inspector-async-hook-teardown-at-debug-end.js}
  12. +1 −1 ...-async-stack-traces-promise-then.js → parallel/test-inspector-async-stack-traces-promise-then.js}
  13. +1 −1 ...-async-stack-traces-set-interval.js → parallel/test-inspector-async-stack-traces-set-interval.js}
  14. 0 test/{inspector/test-bindings.js → parallel/test-inspector-bindings.js}
  15. +1 −1 test/{inspector → parallel}/test-inspector-break-e.js
  16. +3 −3 test/{inspector/test-break-when-eval.js → parallel/test-inspector-break-when-eval.js}
  17. 0 test/{inspector/test-contexts.js → parallel/test-inspector-contexts.js}
  18. +1 −1 test/{inspector/test-debug-brk-flag.js → parallel/test-inspector-debug-brk-flag.js}
  19. +1 −1 test/{inspector/test-debug-end.js → parallel/test-inspector-debug-end.js}
  20. +1 −1 test/{inspector/test-exception.js → parallel/test-inspector-exception.js}
  21. +1 −1 test/{inspector/test-ip-detection.js → parallel/test-inspector-ip-detection.js}
  22. +1 −1 test/{inspector/test-not-blocked-on-idle.js → parallel/test-inspector-not-blocked-on-idle.js}
  23. 0 test/{inspector/test-port-zero-cluster.js → parallel/test-inspector-port-zero-cluster.js}
  24. 0 test/{inspector/test-port-zero.js → parallel/test-inspector-port-zero.js}
  25. +1 −1 test/{inspector/test-scriptparsed-context.js → parallel/test-inspector-scriptparsed-context.js}
  26. +1 −1 .../{inspector/test-stop-profile-after-done.js → parallel/test-inspector-stop-profile-after-done.js}
  27. 0 test/{inspector/test-stops-no-file.js → parallel/test-inspector-stops-no-file.js}
  28. +1 −1 test/{inspector → parallel}/test-inspector.js
  29. 0 test/{inspector → sequential}/test-inspector-enabled.js
  30. 0 test/{inspector/test-port-cluster.js → sequential/test-inspector-port-cluster.js}
  31. +1 −2 vcbuild.bat
View
@@ -409,9 +409,6 @@ test-pummel: all
test-internet: all
$(PYTHON) tools/test.py internet
test-inspector: all
$(PYTHON) tools/test.py inspector
test-node-inspect: $(NODE_EXE)
USE_EMBEDDED_NODE_INSPECT=1 $(NODE) tools/test-npm-package \
--install deps/node-inspect test
View
@@ -19,7 +19,6 @@ On how to run tests in this directory, see
|es-module |Yes |Test ESM module loading.|
|fixtures | |Test fixtures used in various tests throughout the test suite.|
|gc |No |Tests for garbage collection related functionality.|
|inspector |Yes |Tests for the V8 inspector integration.|
|internet |No |Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.|
|known_issues |Yes |Tests reproducing known issues within the system. All tests inside of this directory are expected to fail consistently. If a test doesn't fail on certain platforms, those should be skipped via `known_issues.status`.|
|message |Yes |Tests for messages that are output for various conditions (```console.log```, error messages etc.)|

This file was deleted.

Oops, something went wrong.

This file was deleted.

Oops, something went wrong.
@@ -7,6 +7,9 @@ prefix parallel
[true] # This section applies to all platforms
[$system==win32]
test-inspector-bindings : PASS, FLAKY
test-inspector-debug-end : PASS, FLAKY
test-inspector-stop-profile-after-done: PASS, FLAKY
[$system==linux]
@@ -19,3 +22,5 @@ test-npm-install: PASS,FLAKY
[$system==freebsd]
[$system==aix]
test-inspector-stop-profile-after-done: PASS, FLAKY
@@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('../inspector/inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');
// Even with --inspect, the default async call stack depth is 0. We need a
@@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');
const script = `
@@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('../inspector/inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');
const script = `
@@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper');
const { NodeInstance } = require('../common/inspector-helper');
const assert = require('assert');
const script = `runTest();
@@ -3,7 +3,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
common.skipIf32Bits();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper');
const { NodeInstance } = require('../common/inspector-helper');
const assert = require('assert');
const script = 'setInterval(() => { debugger; }, 50);';
@@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
async function runTests() {
const instance = new NodeInstance(undefined, 'console.log(10)');
@@ -2,10 +2,10 @@
const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const path = require('path');
const { NodeInstance } = require('../common/inspector-helper.js');
const fixtures = require('../common/fixtures');
const script = path.join(path.dirname(module.filename), 'global-function.js');
const script = fixtures.path('inspector-global-function.js');
async function setupDebugger(session) {
console.log('[test]', 'Setting up a debugger');
@@ -5,7 +5,7 @@ common.skipIfInspectorDisabled();
const assert = require('assert');
const { mainScriptPath,
NodeInstance } = require('./inspector-helper.js');
NodeInstance } = require('../common/inspector-helper.js');
async function testBreakpointOnStart(session) {
const commands = [
@@ -2,7 +2,7 @@
const common = require('../common');
common.skipIfInspectorDisabled();
const { strictEqual } = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
async function testNoServerNoCrash() {
console.log('Test there\'s no crash stopping server that was not started');
@@ -5,7 +5,7 @@ const fixtures = require('../common/fixtures');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const script = fixtures.path('throws_error.js');
@@ -4,7 +4,7 @@ const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const os = require('os');
const ip = pickIPv4Address();
@@ -1,7 +1,7 @@
'use strict';
const common = require('../common');
common.skipIfInspectorDisabled();
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
async function runTests() {
const script = 'setInterval(() => {debugger;}, 60000);';
@@ -2,7 +2,7 @@
const common = require('../common');
common.skipIfInspectorDisabled();
common.crashOnUnhandledRejection();
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
const assert = require('assert');
const script = `
@@ -2,7 +2,7 @@
const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { NodeInstance } = require('./inspector-helper.js');
const { NodeInstance } = require('../common/inspector-helper.js');
async function runTests() {
const child = new NodeInstance(['--inspect=0'],
@@ -6,7 +6,7 @@ common.skipIfInspectorDisabled();
const assert = require('assert');
const { mainScriptPath,
readMainScriptSource,
NodeInstance } = require('./inspector-helper.js');
NodeInstance } = require('../common/inspector-helper.js');
function checkListResponse(response) {
assert.strictEqual(1, response.length);
View
@@ -81,7 +81,6 @@ if /i "%1"=="test-addons-napi" set test_args=%test_args% addons-napi&set build
if /i "%1"=="test-simple" set test_args=%test_args% sequential parallel -J&goto arg-ok
if /i "%1"=="test-message" set test_args=%test_args% message&goto arg-ok
if /i "%1"=="test-gc" set test_args=%test_args% gc&set build_testgc_addon=1&goto arg-ok
if /i "%1"=="test-inspector" set test_args=%test_args% inspector&goto arg-ok
if /i "%1"=="test-tick-processor" set test_args=%test_args% tick-processor&goto arg-ok
if /i "%1"=="test-internet" set test_args=%test_args% internet&goto arg-ok
if /i "%1"=="test-pummel" set test_args=%test_args% pummel&goto arg-ok
@@ -536,7 +535,7 @@ echo Failed to create vc project files.
goto exit
:help
echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-inspector/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
echo vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/test-internet/test-pummel/test-simple/test-message/test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module]
echo Examples:
echo vcbuild.bat : builds release build
echo vcbuild.bat debug : builds debug build

0 comments on commit 978629c

Please sign in to comment.