Permalink
Browse files

net: add comments explaining error check

PR-URL: #24222
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information...
bewchy authored and Trott committed Nov 7, 2018
1 parent ff56627 commit 98278584ee2c322655849e6d673ac1739e720b53
Showing with 7 additions and 0 deletions.
  1. +7 −0 lib/net.js
@@ -264,9 +264,16 @@ function Socket(options) {
const { fd } = options;
let err;
// createHandle will throw ERR_INVALID_FD_TYPE if `fd` is not
// a valid `PIPE` or `TCP` descriptor
this._handle = createHandle(fd, false);
err = this._handle.open(fd);
// While difficult to fabricate, in some architectures
// `open` may return an error code for valid file descriptors
// which cannot be opened. This is difficult to test as most
// un-openable fds will throw on `createHandle`
if (err)
throw errnoException(err, 'open');

0 comments on commit 9827858

Please sign in to comment.