Skip to content
Permalink
Browse files

test: use reserved .invalid TLD for invalid address in test

RFC 2606 reserves ithe .invalid top-level-domain for use in "domain
names that are sure to be invalid and which it is obvious at a glance
are invalid." Replace `dne.example.com` which actually isn't guaranteed
to not exist. (example.com is for examples, but at least one address
does in fact exist in that TLD.)

PR-URL: #30545
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
Trott authored and MylesBorins committed Nov 19, 2019
1 parent d802393 commit 9869aaaee46e22a6de0f22904ee83087cd6c3771
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/internet/test-dgram-send-cb-quelches-error.js
@@ -24,7 +24,7 @@ function callbackOnly(err) {
assert.ok(err);
socket.removeListener('error', onEvent);
socket.on('error', mustCall(onError));
socket.send(buffer, 0, buffer.length, 100, 'dne.example.com');
socket.send(buffer, 0, buffer.length, 100, 'dne.invalid');
}

function onEvent(err) {

0 comments on commit 9869aaa

Please sign in to comment.
You can’t perform that action at this time.