Permalink
Browse files

n-api: throw when entry point is null

PR-URL: #20779
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
gabrielschulhof committed May 16, 2018
1 parent 82f1811 commit 9a02de7084e3f3c959d1c7e32bda67cc1d7002bd
@@ -868,6 +868,12 @@ void napi_module_register_by_symbol(v8::Local<v8::Object> exports,
v8::Local<v8::Value> module,
v8::Local<v8::Context> context,
napi_addon_register_func init) {
if (init == nullptr) {
node::Environment::GetCurrent(context)->ThrowError(
"Module has no declared entry point.");
return;
}
// Create a new napi_env for this module or reference one if a pre-existing
// one is found.
napi_env env = v8impl::GetEnv(context);
@@ -0,0 +1,8 @@
{
'targets': [
{
'target_name': 'test_null_init',
'sources': [ 'test_null_init.c' ]
}
]
}
@@ -0,0 +1,7 @@
'use strict';
const common = require('../../common');
const assert = require('assert');
assert.throws(
() => require(`./build/${common.buildType}/test_null_init`),
/Module has no declared entry point[.]/);
@@ -0,0 +1,3 @@
#include <node_api.h>
NAPI_MODULE(NODE_GYP_MODULE_NAME, NULL)

0 comments on commit 9a02de7

Please sign in to comment.