Skip to content
Permalink
Browse files

test: assertion equality fix

In test-net-write-callback.js, when process exits, we check callback
count against the expected value. The assertion is written with the
expected value first and actual value second, but that is the opposite
of the documented argument order. Reverse them to be consistent with
documentation.

PR-URL: #24422
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
NoSkillGirl authored and rvagg committed Nov 17, 2018
1 parent 2777bc4 commit 9b2ab12b8cd9e215f613764c874e0c39cf806aaa
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/pummel/test-net-write-callbacks.js
@@ -67,5 +67,5 @@ server.listen(common.PORT, function() {
});

process.on('exit', function() {
assert.strictEqual(N, cbcount);
assert.strictEqual(cbcount, N);
});

0 comments on commit 9b2ab12

Please sign in to comment.
You can’t perform that action at this time.