Skip to content
Permalink
Browse files

build: don't use -latomic on macOS

Fixes build when using open-source clang.

Builds using Apple clang from Xcode v7 and later were already working,
due to the fact that node's build system misidentifies their
llvm_version as "0.0" and thus the flag wasn't being added.

PR-URL: #30099
Fixes: #30093
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
ryandesign authored and BridgeAR committed Oct 23, 2019
1 parent 72c6460 commit 9b7cf090c76dbfb7e60e8b279ba187100c64774e
Showing with 1 addition and 1 deletion.
  1. +1 −1 node.gyp
@@ -298,7 +298,7 @@
'-Wl,-bnoerrmsg',
],
}],
['OS in ("linux", "mac") and llvm_version != "0.0"', {
['OS == "linux" and llvm_version != "0.0"', {
'libraries': ['-latomic'],
}],
],

0 comments on commit 9b7cf09

Please sign in to comment.
You can’t perform that action at this time.