Permalink
Browse files

child_process: move process.binding('spawn_sync') to internalBinding

PR-URL: #22260
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information...
antsmartian authored and targos committed Sep 4, 2018
1 parent dadd6e1 commit 9c9c01f1839e931b27993439ae7076aba8f25c01
@@ -376,7 +376,8 @@
'tls_wrap',
'util',
'async_wrap',
'url']);
'url',
'spawn_sync']);
process.binding = function binding(name) {
return internalBindingWhitelist.has(name) ?
internalBinding(name) :
@@ -22,7 +22,6 @@ const util = require('util');
const assert = require('assert');
const { internalBinding } = require('internal/bootstrap/loaders');
const { Process } = internalBinding('process_wrap');
const { WriteWrap } = internalBinding('stream_wrap');
const { Pipe, constants: PipeConstants } = internalBinding('pipe_wrap');
@@ -33,7 +32,7 @@ const SocketList = require('internal/socket_list');
const { owner_symbol } = require('internal/async_hooks').symbols;
const { convertToValidSignal } = require('internal/util');
const { isArrayBufferView } = require('internal/util/types');
const spawn_sync = process.binding('spawn_sync');
const spawn_sync = internalBinding('spawn_sync');
const { HTTPParser } = internalBinding('http_parser');
const { freeParser } = require('_http_common');
const { kStateSymbol } = require('internal/dgram');
View
@@ -1100,5 +1100,5 @@ void SyncProcessRunner::KillTimerCloseCallback(uv_handle_t* handle) {
} // namespace node
NODE_BUILTIN_MODULE_CONTEXT_AWARE(spawn_sync,
NODE_MODULE_CONTEXT_AWARE_INTERNAL(spawn_sync,
node::SyncProcessRunner::Initialize)
@@ -13,3 +13,4 @@ assert(process.binding('stream_wrap'));
assert(process.binding('signal_wrap'));
assert(process.binding('contextify'));
assert(process.binding('url'));
assert(process.binding('spawn_sync'));

0 comments on commit 9c9c01f

Please sign in to comment.