From 9d3cdcbebfb077db245c6b4f9a619f9241705124 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C3=ABl=20Zasso?= Date: Sat, 7 Oct 2023 08:33:30 +0200 Subject: [PATCH] deps: V8: cherry-pick 840650f2ff4e MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Original commit message: Merged: [compiler] StackCheck can have side effects Bug: chromium:1452137 (cherry picked from commit e548943e473b020fdc1de6e5543ca31b24d8b7f9) Change-Id: Ibd7c9b02efd12341b452e4c34a635a58a817649f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4637129 Reviewed-by: Toon Verwaest Commit-Queue: Tobias Tebbi Auto-Submit: Tobias Tebbi Commit-Queue: Toon Verwaest Cr-Commit-Position: refs/branch-heads/11.4@{#49} Cr-Branched-From: 8a8a1e7086dacc426965d3875914efa66663c431-refs/heads/11.4.183@{#1} Cr-Branched-From: 5483d8e816e0bbce865cbbc3fa0ab357e6330bab-refs/heads/main@{#87241} Refs: https://github.com/v8/v8/commit/840650f2ff4ee0d96601dd4d2912c0733bf6c925 PR-URL: https://github.com/nodejs/node/pull/50077 Refs: https://github.com/nodejs/nodejs-dependency-vuln-assessments/issues/151 Reviewed-By: Ben Noordhuis Reviewed-By: Tobias Nießen Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Rafael Gonzaga Reviewed-By: Yagiz Nizipli Reviewed-By: Michael Dawson Reviewed-By: Richard Lau --- common.gypi | 2 +- deps/v8/src/compiler/js-operator.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/common.gypi b/common.gypi index 1dca7c9a106e2e..425219c015d7e1 100644 --- a/common.gypi +++ b/common.gypi @@ -36,7 +36,7 @@ # Reset this number to 0 on major V8 upgrades. # Increment by one for each non-official patch applied to deps/v8. - 'v8_embedder_string': '-node.21', + 'v8_embedder_string': '-node.22', ##### V8 defaults for Node.js ##### diff --git a/deps/v8/src/compiler/js-operator.cc b/deps/v8/src/compiler/js-operator.cc index 34f6e9d7b08e71..fb678f80829a2f 100644 --- a/deps/v8/src/compiler/js-operator.cc +++ b/deps/v8/src/compiler/js-operator.cc @@ -1402,7 +1402,7 @@ const Operator* JSOperatorBuilder::CloneObject(FeedbackSource const& feedback, const Operator* JSOperatorBuilder::StackCheck(StackCheckKind kind) { return zone()->New>( // -- IrOpcode::kJSStackCheck, // opcode - Operator::kNoWrite, // properties + Operator::kNoProperties, // properties "JSStackCheck", // name 0, 1, 1, 0, 1, 2, // counts kind); // parameter