Please sign in to comment.
build: fix ninja build failure (GYP patch)
Currently the files specified in libraries in node.gyp `cctest` target are getting a '.lib' extension on windows when generated with ninja. This commit adds a check to see if a file has a '.obj' extension and in that case no '.lib' extension will be added. Also, the LIBS specified in the 'libraries' section are not being included in the --start-group --end-group section which means that these libraries will not be searched causing issue with linkers where the order matters. PR-URL: #12484 Fixes: #12448 Reviewed-By: Benjamin Gruenbaum <firstname.lastname@example.org> Reviewed-By: James M Snell <email@example.com> Reviewed-By: Refael Ackermann <firstname.lastname@example.org> Reviewed-By: Gibson Fahnestock <email@example.com>
- Loading branch information...
Showing with 4 additions and 3 deletions.