Permalink
Browse files

test: improve test-fs-open-flags

* use arrow funcion instead of function expression
* add second argument to method assert.throws
* check error messages from beginning to the end using ^ and $

PR-URL: #10908
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Adrian Estrada <edsadr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information...
Vinícius do Carmo authored and edsadr committed Jan 20, 2017
1 parent ff75e21 commit a024104eecebda372022b671df97439e41f024ec
Showing with 11 additions and 4 deletions.
  1. +11 −4 test/parallel/test-fs-open-flags.js
@@ -37,20 +37,27 @@ assert.strictEqual(stringToFlags('xa+'), O_APPEND | O_CREAT | O_RDWR | O_EXCL);
('+ +a +r +w rw wa war raw r++ a++ w++ x +x x+ rx rx+ wxx wax xwx xxx')
.split(' ')
.forEach(function(flags) {
assert.throws(function() { stringToFlags(flags); });
assert.throws(
() => stringToFlags(flags),
new RegExp(`^Error: Unknown file open flag: ${escapeRegExp(flags)}`)
);
});
assert.throws(
() => stringToFlags({}),
/Unknown file open flag: \[object Object\]/
/^Error: Unknown file open flag: \[object Object\]$/
);
assert.throws(
() => stringToFlags(true),
/Unknown file open flag: true/
/^Error: Unknown file open flag: true$/
);
assert.throws(
() => stringToFlags(null),
/Unknown file open flag: null/
/^Error: Unknown file open flag: null$/
);
function escapeRegExp(string) {
return string.replace(/[\\^$*+?.()|[\]{}]/g, '\\$&');
}

1 comment on commit a024104

@MylesBorins

This comment has been minimized.

Show comment
Hide comment
@MylesBorins

MylesBorins Mar 8, 2017

Member

PR URL is not correct

Member

MylesBorins commented on a024104 Mar 8, 2017

PR URL is not correct

Please sign in to comment.