Permalink
Browse files

benchmark: terminate child process on Windows

test-benchmark-child-process failures reveal that
child-process-exec-stdout benchmark sometimes leaves around a stray
yes.exe process. Add code to terminate the process.

PR-URL: #12658
Ref: #12560
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Trott committed Apr 25, 2017
1 parent d8f8096 commit a1a54ca3f1c55d3e7fb56fa566c98bc6c0a2dd9a
Showing with 8 additions and 3 deletions.
  1. +8 −2 benchmark/child_process/child-process-exec-stdout.js
  2. +0 −1 test/sequential/sequential.status
@@ -10,7 +10,8 @@ const bench = common.createBenchmark(main, {
dur: [5]
});
const exec = require('child_process').exec;
const child_process = require('child_process');
const exec = child_process.exec;
function main(conf) {
bench.start();
@@ -29,7 +30,12 @@ function main(conf) {
});
setTimeout(function() {
child.kill();
bench.end(bytes);
if (process.platform === 'win32') {
// Sometimes there's a yes.exe process left hanging around on Windows...
child_process.execSync(`taskkill /f /t /pid ${child.pid}`);
} else {
child.kill();
}
}, dur * 1000);
}
@@ -7,7 +7,6 @@ prefix sequential
[true] # This section applies to all platforms
[$system==win32]
test-benchmark-child-process : PASS,FLAKY
[$system==linux]

0 comments on commit a1a54ca

Please sign in to comment.