Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: create env->inspector_console_api_object earlier
Previously we create env->inspector_console_api_object() when `process.binding('inspector')` is called, which may be too late if the inspector console is used before the first call to `process.binding('inspector')` - that is possible when using `--inspect-brk-node`. Setting a breakpoint and using the inspector console before that would crash the process. This patch moves the initialization of the console API object to the point when Environment is initialized so that `installAdditionalCommandLineAPI()` can be essentially a noop if we use the inspector console before the inspector binding is initialized instead of crashing on an empty object. PR-URL: #24906 Reviewed-By: Anna Henningsen <firstname.lastname@example.org> Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: Franziska Hinkelmann <firstname.lastname@example.org>
- Loading branch information
Showing with 8 additions and 6 deletions.