Permalink
Browse files

test: improve tests in pummel/test-exec

* add asset.strictEqual to stdout and stderr. Fixes no-unused-vars.
* replace double quotes with single

PR-URL: #10757
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information...
chasestarr authored and jasnell committed Jan 12, 2017
1 parent dad98bf commit a2af61afc62bb6638ed38ce6341f3cc24c0d5e4d
Showing with 6 additions and 0 deletions.
  1. +6 −0 test/pummel/test-exec.js
View
@@ -63,6 +63,8 @@ exec(SLEEP3_COMMAND, { timeout: 50 }, function(err, stdout, stderr) {
assert.ok(err);
assert.ok(err.killed);
assert.strictEqual(err.signal, 'SIGTERM');
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
});
@@ -85,6 +87,8 @@ function killMeTwiceCallback(err, stdout, stderr) {
assert.ok(err);
assert.ok(err.killed);
assert.strictEqual(err.signal, 'SIGTERM');
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
// the timeout should still be in effect
console.log('\'sleep 3\' was already killed. Took %d ms', diff);
@@ -96,6 +100,8 @@ exec('python -c "print 200000*\'C\'"', {maxBuffer: 1000},
function(err, stdout, stderr) {
assert.ok(err);
assert.ok(/maxBuffer/.test(err.message));
assert.strictEqual(stdout, '');
assert.strictEqual(stderr, '');
});

0 comments on commit a2af61a

Please sign in to comment.