Permalink
Browse files

inspector: do not prompt to use localhost

There are multiple reports of Windows7 not being able to resolve
localhost on some setups (web search also confirms that). This change
will advertise "127.0.0.1" as inspector host name.

Fixes: #9382
Fixes: #9188
PR-URL: #9451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information...
Eugene Ostroukhov
Eugene Ostroukhov committed Nov 3, 2016
1 parent 1aa595e commit a41b41a5409e41907982504dc0d6fd0c8c7968f9
Showing with 2 additions and 2 deletions.
  1. +1 −1 src/inspector_agent.cc
  2. +1 −1 test/inspector/test-inspector.js
View
@@ -39,7 +39,7 @@ static const uint8_t PROTOCOL_JSON[] = {
std::string GetWsUrl(int port, const std::string& id) {
char buf[1024];
snprintf(buf, sizeof(buf), "localhost:%d/%s", port, id.c_str());
snprintf(buf, sizeof(buf), "127.0.0.1:%d/%s", port, id.c_str());
return buf;
}
@@ -11,7 +11,7 @@ function checkListResponse(err, response) {
assert.ok(response[0]['devtoolsFrontendUrl']);
assert.ok(
response[0]['webSocketDebuggerUrl']
.match(/ws:\/\/localhost:\d+\/[0-9A-Fa-f]{8}-/));
.match(/ws:\/\/127.0.0.1:\d+\/[0-9A-Fa-f]{8}-/));
}
function checkVersion(err, response) {

0 comments on commit a41b41a

Please sign in to comment.