Permalink
Browse files

test: remove hidden use of common.PORT in parallel tests

common.hasMultiLocalhost() uses common.PORT under the hood. This is
problematic in parallel tests because another test using port 0 to
get an arbitrary open port may end up getting common.PORT before the
test using common.PORT gets it.

Therefore, change common.PORT to port 0 in common.hasMultiLocalhost().

Backport-PR-URL: #17771
PR-URL: #17466
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information...
Trott authored and MylesBorins committed Dec 5, 2017
1 parent b1b9753 commit a528d573ce4e948e4e2274f3be9ddf41ece40f72
Showing with 1 addition and 1 deletion.
  1. +1 −1 test/common/index.js
View
@@ -466,7 +466,7 @@ function _mustCallInner(fn, criteria, field) {
exports.hasMultiLocalhost = function hasMultiLocalhost() {
const TCP = process.binding('tcp_wrap').TCP;
const t = new TCP();
const ret = t.bind('127.0.0.2', exports.PORT);
const ret = t.bind('127.0.0.2', 0);
t.close();
return ret === 0;
};

0 comments on commit a528d57

Please sign in to comment.