Skip to content
Permalink
Browse files

src: remove node_options-inl.h from header files

Fix unnecessary inclusion of node_options-inl.h into env.h via
inspector_agent.h, causing almost all of src/ to recompile on any change
to the options parser. Its intended that *-inl.h header files are only
included into the src files that call the inline methods.

PR-URL: #27538
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information...
sam-github authored and targos committed May 2, 2019
1 parent d648ecc commit a758f9bdf5391deb492b6010801d1442c37e872d
Showing with 3 additions and 1 deletion.
  1. +1 −0 src/inspector_agent.cc
  2. +1 −1 src/inspector_agent.h
  3. +1 −0 src/node_worker.cc
@@ -9,6 +9,7 @@
#include "node/inspector/protocol/Protocol.h"
#include "node_errors.h"
#include "node_internals.h"
#include "node_options-inl.h"
#include "node_process.h"
#include "node_url.h"
#include "v8-inspector.h"
@@ -6,7 +6,7 @@
#error("This header can only be used when inspector is enabled")
#endif

#include "node_options-inl.h"
#include "node_options.h"
#include "v8.h"

#include <cstddef>
@@ -2,6 +2,7 @@
#include "debug_utils.h"
#include "node_errors.h"
#include "node_buffer.h"
#include "node_options-inl.h"
#include "node_perf.h"
#include "util.h"
#include "async_wrap-inl.h"

0 comments on commit a758f9b

Please sign in to comment.
You can’t perform that action at this time.