Permalink
Browse files

test: increase coverage for http2.connect

Added checks for connecting using https and an unsupported protocol.

PR-URL: #14832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information...
michaalbert authored and addaleax committed Aug 14, 2017
1 parent 39dd230 commit aa24777c444d8d2ad4a48b3952856139f0c62c14
Showing with 40 additions and 22 deletions.
  1. +40 −22 test/parallel/test-http2-connect.js
@@ -1,31 +1,49 @@
// Flags: --expose-http2
'use strict';
const { mustCall, hasCrypto, skip } = require('../common');
const { mustCall, hasCrypto, skip, expectsError } = require('../common');
if (!hasCrypto)
skip('missing crypto');
const { doesNotThrow } = require('assert');
const { doesNotThrow, throws } = require('assert');
const { createServer, connect } = require('http2');
{
const server = createServer();
server.listen(0, mustCall(() => {
const authority = `http://localhost:${server.address().port}`;
const options = {};
const listener = () => mustCall();
const server = createServer();
server.listen(0, mustCall(() => {
const authority = `http://localhost:${server.address().port}`;
const options = {};
const listener = () => mustCall();
const clients = new Set();
doesNotThrow(() => clients.add(connect(authority)));
doesNotThrow(() => clients.add(connect(authority, options)));
doesNotThrow(() => clients.add(connect(authority, options, listener())));
doesNotThrow(() => clients.add(connect(authority, listener())));
const clients = new Set();
doesNotThrow(() => clients.add(connect(authority)));
doesNotThrow(() => clients.add(connect(authority, options)));
doesNotThrow(() => clients.add(connect(authority, options, listener())));
doesNotThrow(() => clients.add(connect(authority, listener())));
for (const client of clients) {
client.once('connect', mustCall((headers) => {
client.destroy();
clients.delete(client);
if (clients.size === 0) {
server.close();
}
}));
}
}));
}
for (const client of clients) {
client.once('connect', mustCall((headers) => {
client.destroy();
clients.delete(client);
if (clients.size === 0) {
server.close();
}
}));
}
}));
// check for https as protocol
{
const authority = 'https://localhost';
doesNotThrow(() => connect(authority));
}
// check for error for an invalid protocol (not http or https)
{
const authority = 'ssh://localhost';
throws(() => {
connect(authority);
}, expectsError({
code: 'ERR_HTTP2_UNSUPPORTED_PROTOCOL',
type: Error
}));
}

0 comments on commit aa24777

Please sign in to comment.