Permalink
Browse files

test: make test-http-agent-maxsockets robust

On a slow/busy machine, `test-http-agent-maxsockets` can fail if the
test takes longer than 5 seconds because that is the default value for
`server.keepAliveTimeout`. Disable `keepAliveTimeout` to make the test
robust.

PR-URL: #15192
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
  • Loading branch information...
Trott authored and BridgeAR committed Sep 5, 2017
1 parent af15b75 commit aa3b96ab748340d2c22f373a01a075c67da903c0
Showing with 2 additions and 0 deletions.
  1. +2 −0 test/parallel/test-http-agent-maxsockets.js
@@ -15,6 +15,8 @@ const server = http.createServer(common.mustCall((req, res) => {
res.end('hello world');
}, 2));
server.keepAliveTimeout = 0;
function get(path, callback) {
return http.get({
host: 'localhost',

0 comments on commit aa3b96a

Please sign in to comment.