Skip to content
Permalink
Browse files

test: check that --insecure-http-parser works

Test that using --insecure-http-parser will disable validation of
invalid characters in HTTP headers.

See:
- #30567

PR-URL: #31253
Backport-PR-URL: #30473
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
  • Loading branch information
sam-github committed Jan 7, 2020
1 parent 496736f commit ab1fcb89cb74e4bc7f0df3826090112388435d3a
Showing with 70 additions and 0 deletions.
  1. +35 −0 test/parallel/test-http-insecure-parser-legacy.js
  2. +35 −0 test/parallel/test-http-insecure-parser.js
@@ -0,0 +1,35 @@
// Flags: --insecure-http-parser --http-parser=legacy

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');

const server = http.createServer(function(req, res) {
assert.strictEqual(req.headers['content-type'], 'text/te\bt');
req.pipe(res);
});

server.listen(0, common.mustCall(function() {
const bufs = [];
const client = net.connect(
this.address().port,
function() {
client.write(
'GET / HTTP/1.1\r\n' +
'Content-Type: text/te\x08t\r\n' +
'Connection: close\r\n\r\n');
}
);
client.on('data', function(chunk) {
bufs.push(chunk);
});
client.on('end', common.mustCall(function() {
const head = Buffer.concat(bufs)
.toString('latin1')
.split('\r\n')[0];
assert.strictEqual(head, 'HTTP/1.1 200 OK');
server.close();
}));
}));
@@ -0,0 +1,35 @@
// Flags: --insecure-http-parser

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
const net = require('net');

const server = http.createServer(function(req, res) {
assert.strictEqual(req.headers['content-type'], 'text/te\bt');
req.pipe(res);
});

server.listen(0, common.mustCall(function() {
const bufs = [];
const client = net.connect(
this.address().port,
function() {
client.write(
'GET / HTTP/1.1\r\n' +
'Content-Type: text/te\x08t\r\n' +
'Connection: close\r\n\r\n');
}
);
client.on('data', function(chunk) {
bufs.push(chunk);
});
client.on('end', common.mustCall(function() {
const head = Buffer.concat(bufs)
.toString('latin1')
.split('\r\n')[0];
assert.strictEqual(head, 'HTTP/1.1 200 OK');
server.close();
}));
}));

0 comments on commit ab1fcb8

Please sign in to comment.
You can’t perform that action at this time.