Skip to content

Commit

Permalink
src: fix crash with SyntheticModule#setExport
Browse files Browse the repository at this point in the history
Use the new non-deprecated V8 API for that.

PR-URL: #30062
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
targos authored and Trott committed Oct 26, 2019
1 parent d29f0ed commit ab78d4d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion src/module_wrap.cc
Expand Up @@ -1500,7 +1500,7 @@ void ModuleWrap::SetSyntheticExport(
Local<Value> export_value = args[1];

Local<Module> module = obj->module_.Get(isolate);
module->SetSyntheticModuleExport(export_name, export_value);
USE(module->SetSyntheticModuleExport(isolate, export_name, export_value));
}

void ModuleWrap::Initialize(Local<Object> target,
Expand Down
3 changes: 0 additions & 3 deletions test/parallel/test-vm-module-synthetic.js
Expand Up @@ -36,8 +36,6 @@ const assert = require('assert');
});
}

// https://bugs.chromium.org/p/v8/issues/detail?id=9828
/*
{
const s = new SyntheticModule([], () => {});
await s.link(() => {});
Expand All @@ -47,7 +45,6 @@ const assert = require('assert');
name: 'ReferenceError',
});
}
*/

{
const s = new SyntheticModule([], () => {});
Expand Down

0 comments on commit ab78d4d

Please sign in to comment.