Permalink
Browse files

src: fix -Wunused-result compiler warning

Fix a warning that was introduced in commit 67af1ad ("src: refactor
CopyProperties to remove JS") from a few days ago.  This particular
change was suggested by me, mea culpa.

Fixes the following warning:

    ../src/node_contextify.cc:151:13: warning: ignoring return
    value of function declared with warn_unused_result attribute
    [-Wunused-result]
                sandbox_obj->DefineProperty(context, key, *desc);

PR-URL: #11197
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information...
bnoordhuis authored and italoacasas committed Feb 6, 2017
1 parent f0eba78 commit af06f62e3567af8d4b9761c3878ca770d7bec976
Showing with 1 addition and 1 deletion.
  1. +1 −1 src/node_contextify.cc
View
@@ -148,7 +148,7 @@ class ContextifyContext {
desc->set_enumerable(desc_vm_context
->Get(context, env()->enumerable_string()).ToLocalChecked()
->BooleanValue(context).FromJust());
- sandbox_obj->DefineProperty(context, key, *desc);
+ CHECK(sandbox_obj->DefineProperty(context, key, *desc).FromJust());
};
if (is_accessor) {

0 comments on commit af06f62

Please sign in to comment.